Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add goreturns #1888

Closed
wants to merge 1 commit into from
Closed

Conversation

hori-ryota
Copy link
Contributor

I wanted to use goreturns instead of goimports, so I added it.

I think that this issue has already been resolved.
goreturns configuration · Issue #208 · fatih/vim-go

Although it is not a perfect implementation, I was able to confirm the operation for the time being. Can you positively think about it?

@hori-ryota hori-ryota force-pushed the feature/goreturns branch 2 times, most recently from 4d6a5a2 to 0272bec Compare July 19, 2018 13:09
@fatih
Copy link
Owner

fatih commented Aug 6, 2018

Hi @hori-ryota

Do we really need a new command for this? I regret adding :GoImports already and believe adding another command that overwrites :GoFmt is not needed. Doesn't goreturns works if you just replace the binary? Or is there something else to do?

@hori-ryota
Copy link
Contributor Author

As for goreturns, it is enough to overwrite goimports because the usage of the -srcdir, -w option is the same. That idea was missing to me. Thank you very much.

@hori-ryota hori-ryota closed this Aug 6, 2018
@hori-ryota hori-ryota deleted the feature/goreturns branch August 6, 2018 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants